Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework FPI tests #917

Closed
Fumuran opened this issue Oct 12, 2024 · 3 comments
Closed

Rework FPI tests #917

Fumuran opened this issue Oct 12, 2024 · 3 comments
Assignees
Labels
tests Improvements to testing
Milestone

Comments

@Fumuran
Copy link
Contributor

Fumuran commented Oct 12, 2024

What should be done?

See #896 (comment)

How should it be done?

The indexes of the obtaining values should be changed from 0 to 1 and 2 to get the value from the first slot and a map from the second.

When is this task done?

This task is done when the tests will check that we can correctly obtain elements not only from 0th storage slot.

Additional context

No response

@Fumuran Fumuran self-assigned this Oct 12, 2024
@Fumuran Fumuran added the tests Improvements to testing label Oct 15, 2024
@bobbinth bobbinth added this to the v0.6 milestone Oct 31, 2024
@bobbinth bobbinth modified the milestones: v0.6, v0.7 Nov 7, 2024
@bobbinth
Copy link
Contributor

@Fumuran - is this now closed by #957 or is there anything else outstanding?

@Fumuran
Copy link
Contributor Author

Fumuran commented Nov 21, 2024

There are some issues about FPI tests which I described in the PR, but in terms of this issue the work is done, so I think we can close it.

@Fumuran
Copy link
Contributor Author

Fumuran commented Nov 21, 2024

Closed by #957.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Improvements to testing
Projects
Status: Done
Development

No branches or pull requests

2 participants