Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes to GH actions v4 and some nits npx was complaining about #164

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

Dominik1999
Copy link
Contributor

@Dominik1999 Dominik1999 commented Feb 19, 2024

GH pages wasn't able to build the new playground due to

  • a deprecated version of GH actions
  • some linting problems

This PR addresses it and I tested the build.

@Dominik1999 Dominik1999 force-pushed the dominik_update_gh_actions branch from 5f486b0 to c177109 Compare February 19, 2024 11:25
@Dominik1999 Dominik1999 force-pushed the dominik_update_gh_actions branch from c177109 to 65a6222 Compare February 19, 2024 11:31
Copy link

sonarcloud bot commented Feb 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Dominik1999 Dominik1999 changed the title changes to node 20 changes to GH actions v4 and some nits npx was complaining about Feb 19, 2024
Copy link
Contributor

@hackaugusto hackaugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested it. LGTM

@@ -11,7 +11,7 @@ jobs:

steps:
- name: Checkout 🛎️
uses: actions/checkout@v3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -21,7 +21,7 @@ const MemoryInfo = (props: MemoryInfoProps): JSX.Element => {
<div className="flex flex-wrap overflow-auto h-40">
{props.debugOutput &&
formatMemory(props.debugOutput.memory).map(
(memoryString, index) => (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this a bug?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eslint complained because index was not used

@Dominik1999 Dominik1999 merged commit afc28aa into main Feb 19, 2024
3 checks passed
@Dominik1999 Dominik1999 deleted the dominik_update_gh_actions branch February 19, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants