-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changes to GH actions v4 and some nits npx was complaining about #164
Conversation
5f486b0
to
c177109
Compare
c177109
to
65a6222
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested it. LGTM
@@ -11,7 +11,7 @@ jobs: | |||
|
|||
steps: | |||
- name: Checkout 🛎️ | |||
uses: actions/checkout@v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -21,7 +21,7 @@ const MemoryInfo = (props: MemoryInfoProps): JSX.Element => { | |||
<div className="flex flex-wrap overflow-auto h-40"> | |||
{props.debugOutput && | |||
formatMemory(props.debugOutput.memory).map( | |||
(memoryString, index) => ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was this a bug?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eslint
complained because index
was not used
GH pages wasn't able to build the new playground due to
This PR addresses it and I tested the build.