Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: bumping up to Miden v0.7 to clean up a bit #159

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

Dominik1999
Copy link
Contributor

Removing the transaction example and updating to Miden VM 0.7

@Dominik1999 Dominik1999 requested a review from phklive January 4, 2024 10:18
@Dominik1999 Dominik1999 force-pushed the dominik_clean_up_examples_repo branch from 2596dc4 to 989aa69 Compare January 4, 2024 10:19
Copy link

@phklive phklive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Well done, minor nits and questions.

Running correctly locally.

benchmarking-cli/src/main.rs Show resolved Hide resolved
benchmarking-cli/Cargo.toml Show resolved Hide resolved
playground/miden-wasm/src/transaction.rs Show resolved Hide resolved
@Dominik1999 Dominik1999 force-pushed the dominik_clean_up_examples_repo branch from 989aa69 to d70e990 Compare January 4, 2024 11:57
Copy link

sonarcloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Dominik1999 Dominik1999 merged commit c00cb89 into main Jan 4, 2024
3 checks passed
@Dominik1999 Dominik1999 deleted the dominik_clean_up_examples_repo branch January 4, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants