New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`Diagnostic::labels` are not printed #380

Open

greenhat opened this issue Jan 31, 2025 · 1 comment

Labels

bug

Contributor

greenhat commented Jan 31, 2025 •

edited

Loading

To reproduce:

remove the https://github.com/0xPolygonMiden/compiler/blob/greenhat/i363-op-tests/frontend-wasm2/src/code_translator/tests.rs#L33-L40 extra label printing;
run any failing test due to Operation operands and result verification fails due to the types being Type::Unknown #378;
observe the labels are not shown;

Both Display and Debug implementation. I suspect the empty SourceSpan is the reason.

The text was updated successfully, but these errors were encountered:

greenhat added the bug label

Contributor Author

greenhat commented Jan 31, 2025

OTOH, it might be worthwhile to start providing source spans in tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment