feat: implement Tool for Agent #704
Conversation
|
|
||
| async fn definition(&self, _prompt: String) -> ToolDefinition { | ||
| ToolDefinition { | ||
| name: <Self as Tool>::name(self), |
There was a problem hiding this comment.
This is distinguish between the Agent::name method and the Tool::name trait method. The Tool::name trait method implementation here returns a valid Tool name.
This is important because the Agent::name method could return an invalid Tool name - either an invalid one set by the user, or, if not set, the default name "Unnamed Agent" (which is invalid due to the whitespace).
|
@joshua-mo-143 I have tested this locally by modifying the Would you like me to add/amend an example to demonstrate this? |
Yeah that would be great actually |
joshua-mo-143
left a comment
joshua-mo-143
left a comment
There was a problem hiding this comment.
One change required but that's basically it
rig-core/src/agent/tool.rs
Outdated
| }; | ||
| use serde::{Deserialize, Serialize}; | ||
|
|
||
| #[derive(Debug, Clone, Serialize, Deserialize)] |
There was a problem hiding this comment.
Use schemars::JsonSchema (the derive macro) here - it's much easier to convert into a JSON schema rather than using fragile JSON
There was a problem hiding this comment.
Makes sense. Done.
joshua-mo-143
left a comment
joshua-mo-143
left a comment
There was a problem hiding this comment.
Sorry missed something last review - final change and then we'll merge!
|
Nice, i wasn't able to finish my branch for this. glad it got in there! |
3 participants
Closes #696.
ToolforAgent, so that anAgentcan be added as a Tool to be used by another Agent.agent_with_agent_toolto demonstrate an Agent using another Agent as a Tool.