feat: Stream cancellation using AbortHandle #525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks great! I will try and review this when I am able to do so if nobody else beats me to it. |
Contributor
|
Hey @rajiknows just letting you know there's a merge conflict that needs fixing before I can review your PR. This looks pretty good, I think it just needs some testing to check that everything works |
Contributor
Author
|
@joshua-mo-143 lets try to resolve the conflicts .. |
Contributor
|
@rajiknows Looks like this is failing due to some clippy/fmt errors. If you fix them I'll have a look and run the CI again. |
joshua-mo-143
approved these changes
Jul 1, 2025
Contributor
joshua-mo-143
left a comment
joshua-mo-143
left a comment
There was a problem hiding this comment.
lgtm - just need to fix lints/errors
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #491
new stream api:
stream.cancel()cancels the ongoing stream.