Skip to content

fix(ollama): use lower-case key for ToolResult serialization #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2025
Merged

fix(ollama): use lower-case key for ToolResult serialization #504

merged 1 commit into from
Jun 11, 2025

Conversation

@lnicola
Copy link
Contributor

@lnicola lnicola commented Jun 10, 2025

serde attributes don't stack like this, so we would send "role": "Tool".

joshua-mo-143
joshua-mo-143 approved these changes Jun 11, 2025
View reviewed changes
Copy link
Contributor

@joshua-mo-143 joshua-mo-143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thank you!

@joshua-mo-143 joshua-mo-143 merged commit cfd7d8c into 0xPlaygrounds:main Jun 11, 2025
5 checks passed
@github-actions github-actions bot mentioned this pull request Jun 11, 2025
Merged
@lnicola lnicola deleted the patch-1 branch June 11, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshua-mo-143 joshua-mo-143 joshua-mo-143 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lnicola @joshua-mo-143