Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and remove queue bindings while runing #105

Closed
liviumanea opened this issue Apr 15, 2023 · 2 comments
Closed

Add and remove queue bindings while runing #105

liviumanea opened this issue Apr 15, 2023 · 2 comments

Comments

@liviumanea
Copy link

How would I go about dinamically adding or removing queue bindings after the client has started ?

@bombsimon
Copy link
Member

Hey!

This is sadly not supported currently. Here is where we start consuming from all the bindings which is only invoked when calling ListenAndServe.

Depending on your setup a workaround could be to bind a new binding and then call Stop followed by Start. Stop will drain incoming requests and finish process any in flight request so it should be graceful, however it's obviously not ideal.

If we move the consumer tags so we can access them in cancelConsumers (maybe move that function to an associate function on the server) we could easily add and start (and stop) consuming on bindings dynamically at runtime.

PRs welcome!

@akarl
Copy link
Collaborator

akarl commented Jan 7, 2025

If this is a feature that is still important. Feel free to re-open!

@akarl akarl closed this as completed Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants