Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.0.5 Flow Types are broken #67

Closed
marcusdarmstrong opened this issue Jan 10, 2020 · 2 comments · Fixed by #68
Closed

4.0.5 Flow Types are broken #67

marcusdarmstrong opened this issue Jan 10, 2020 · 2 comments · Fixed by #68

Comments

@marcusdarmstrong
Copy link

Sampling:

Error ----------------------------------------------- node_modules/wonka/dist/types/src/Wonka_operators.gen.js.flow:3:10

Cannot import the type operatorT as a value. Use import type instead.

     1| // @flow
     2|
     3| import { operatorT as Wonka_types_operatorT } from "./Wonka_types.gen";
     4| import { sourceT as Wonka_types_sourceT } from "./Wonka_types.gen";
     5| declare export var buffer: <a, b>(
     6|   _1: Wonka_types_sourceT<a>


Error ----------------------------------------------- node_modules/wonka/dist/types/src/Wonka_operators.gen.js.flow:4:10

Cannot import the type sourceT as a value. Use import type instead.

     1| // @flow
     2|
     3| import { operatorT as Wonka_types_operatorT } from "./Wonka_types.gen";
     4| import { sourceT as Wonka_types_sourceT } from "./Wonka_types.gen";
     5| declare export var buffer: <a, b>(
     6|   _1: Wonka_types_sourceT<a>
     7| ) => Wonka_types_operatorT<b, b[]>;


Error --------------------------------------------------- node_modules/wonka/dist/types/src/Wonka_sinks.gen.js.flow:3:10

Cannot import the type sourceT as a value. Use import type instead.

     1| // @flow
     2|
     3| import { sourceT as Wonka_types_sourceT } from "./Wonka_types.gen";
     4| import { subscriptionT as Wonka_types_subscriptionT } from "./Wonka_types.gen";
     5| export type subscribeConsumerT<a> = (
     6|   _1: Wonka_types_sourceT<a>

Looks like it's due to this: joarwilk/flowgen#74

I'll be working around this with a local fork of the generated typedefs, but I figured you'd want to know.

@kitten
Copy link
Member

kitten commented Jan 10, 2020

Oh awesome, thanks for letting me know! I’ll put the flow checks back in place and will see whether I can get this fixed with some quick finds&replaces in the generate script 👍

@kitten
Copy link
Member

kitten commented Jan 10, 2020

@marcusdarmstrong Would you like to give #68 a try? Pika CI should build a temporary package, which will show up here once it's done: https://github.com/kitten/wonka/pull/68/checks?check_run_id=383809151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants