Skip to content

Commit 8017f87

Browse files
akpm00hnaz
authored andcommitted
relay-use-irq_work-instead-of-plain-timer-for-deferred-wakeup-checkpatch-fixes
ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 0123456789ab ("commit description")' torvalds#12: commit 7c9cb38 WARNING: line over 80 characters torvalds#87: FILE: kernel/relay.c:337: + struct rchan_buf *buf = container_of(work, struct rchan_buf, wakeup_work); WARNING: waitqueue_active without comment torvalds#119: FILE: kernel/relay.c:772: + if (waitqueue_active(&buf->read_wait)) { total: 1 errors, 2 warnings, 70 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. ./patches/relay-use-irq_work-instead-of-plain-timer-for-deferred-wakeup.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Akash Goel <[email protected]> Signed-off-by: Andrew Morton <[email protected]>
1 parent 00079e4 commit 8017f87

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

kernel/relay.c

+3-1
Original file line numberDiff line numberDiff line change
@@ -334,7 +334,9 @@ static struct rchan_callbacks default_channel_callbacks = {
334334
*/
335335
static void wakeup_readers(struct irq_work *work)
336336
{
337-
struct rchan_buf *buf = container_of(work, struct rchan_buf, wakeup_work);
337+
struct rchan_buf *buf;
338+
339+
buf = container_of(work, struct rchan_buf, wakeup_work);
338340
wake_up_interruptible(&buf->read_wait);
339341
}
340342

0 commit comments

Comments
 (0)