Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUESTION] GO RELOADED error in assignment #2787

Open
BjornMikael opened this issue Oct 29, 2024 · 1 comment
Open

[QUESTION] GO RELOADED error in assignment #2787

BjornMikael opened this issue Oct 29, 2024 · 1 comment
Assignees
Labels
🙋 question Questions or other issues

Comments

@BjornMikael
Copy link

I have walked through the 01 edu's "Go-Reloaded" assignment when the following issue crossed my eyes and mind:

"Every instance of a should be turned into an if the next word begins with a vowel (a, e, i, o, u) or a h. (Ex: "There it was. A amazing rock!" -> "There it was. An amazing rock!")."

Now, this task given gives cause for concern because we are being told that "Every instance of a should be turned into an if the next word begins with a vowel (a, e, i, o, u) or a h."

Well, a problematic situation occurs if/when we look closely (for example) into the following examples:

  1. Well, I just got into town about a hour ago --> FIX: Well, I just got into town about an hour ago --> NO PROBLEM HERE, fix works 100% as "hour" is pronounced without the "h".
  1. Yes, I live on a house upon Hollywood Hills --> FIX: Yes, I live on an house upon Hollywood Hills --> 100% PROBLEM, because "house" is pronounced WITH the "h", not without.

So in effect with these instructions given we would have a flawed text completion/editing/auto-correction in the real world, which is probably not the end result we were looking for. Just my two cents.

@Oumaimafisaoui Oumaimafisaoui assigned MSilva95 and unassigned MSilva95 Oct 31, 2024
@HarryVasanth HarryVasanth changed the title GO RELOADED error in assignment [QUESTION] GO RELOADED error in assignment Nov 6, 2024
@HarryVasanth HarryVasanth added the 🙋 question Questions or other issues label Nov 6, 2024
@pedrodesu
Copy link
Contributor

Hello @BjornMikael!

We appreciate you taking the time to think about the correctness of the exercise.

Now, one important thing to bear in mind, is that while your reasoning is definitely valid and not every example would be correct under this logic, this hardly matters for the given exercise, as it's beyond its point. The exercise focuses on the user being able to do that parsing and substitution accordingly - whether the context is 100% correct gramatically is somewhat irrelevant for the purpose of the exercise.

With that in mind, I do agree striving for correctness and polishing the exercise is always a good idea. However, I'm not entirely sure on how we could make this section of the exercise gramatically correct without changing its context (checking and replacing based on whether we have a vowel/h at the start).

I'd like to ask you if you have any further ideas on how we can make this more accurate. We're of course open to changing the context/phrashing of that section of the exercise if that means making it more gramatically sound - as long as the logic behind remains equivalent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙋 question Questions or other issues
Projects
None yet
Development

No branches or pull requests

4 participants