Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M.2 warning displays escape code instead of using yellow color #46

Closed
herbingk opened this issue Jan 5, 2024 · 2 comments
Closed

M.2 warning displays escape code instead of using yellow color #46

herbingk opened this issue Jan 5, 2024 · 2 comments

Comments

@herbingk
Copy link

herbingk commented Jan 5, 2024

M.2 warning displays escape code instead of using yellow color. Occurs with the Synology_HDD_db script as well.

Seems like the -e param is missing from the echo statement:

echo "${Yellow}WARNING${Off} Don't store this script on an NVMe volume!"

Sample output:

Synology_enable_Deduplication v1.2.15
DS1621+ DSM 7.2.1-69057-3
StorageManager 1.0.0-0017

Using options: -c
Running from: /volume1/admin/Synology_Enable_Dedupe/syno_enable_dedupe.sh
\e[0;33mWARNING\e[0m Don't store this script on an NVMe volume!

Thanks for loooking into it.

@007revad
Copy link
Owner

007revad commented Jan 5, 2024

Thanks.

I just checked and 5 of my scripts are missing the -e for that warning!

  • syno_hdd_db.sh
  • enable_m2_volume.sh
  • enable_dedupe.sh
  • syno_enable_m2_card.sh
  • syno_enable_eunit.sh

@007revad 007revad mentioned this issue Jan 7, 2024
@007revad
Copy link
Owner

007revad commented Jan 7, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants