Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flurry of Blows doesn't increment combo #1722

Open
jessdwitch opened this issue May 28, 2024 · 2 comments
Open

Flurry of Blows doesn't increment combo #1722

jessdwitch opened this issue May 28, 2024 · 2 comments
Assignees
Milestone

Comments

@jessdwitch
Copy link

If a monk has a sai equipped she builds combo on-hit with "melee or thrown weapons", but Flurry of Blows does not increment the counter at all. I don't know if this also applies to other combo weapons.

@00-Evan
Copy link
Owner

00-Evan commented May 28, 2024

Thanks for the report. I am aware of this, currently flurry of blows doesn't trigger a few on-hit effects that it probably should. Even if the decision here is that it shouldn't (i.e. fists aren't weapons), it should at least be that way intentionally.

@00-Evan 00-Evan self-assigned this May 28, 2024
@00-Evan 00-Evan added this to the 2.4.2 milestone May 28, 2024
@00-Evan
Copy link
Owner

00-Evan commented Jun 4, 2024

Delaying this to v2.5.0 as it requires some internal code changes to attack logic that are more wide-reaching than first suspected.

@00-Evan 00-Evan modified the milestones: 2.4.2, 2.5.0 Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants