Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Movie Finder #1

Closed
wants to merge 46 commits into from
Closed

Movie Finder #1

wants to merge 46 commits into from

Conversation

jcy2704
Copy link
Owner

@jcy2704 jcy2704 commented Apr 10, 2021

Movie Finder

API

  • The Movie DB API

Features

  • Catalogue of Movies

    • Trending (Hero Image)
    • Popular
    • Top Rated
    • Upcoming
    • Modals with details for each movie
  • Filter by Genre

    • Action
    • Adventure
    • Fantasy
    • and more
    • Modal for filter options
    • Reset filter button

@addod19
Copy link

addod19 commented Apr 12, 2021

Movie Finder

API

  • The Movie DB API

Features

  • Catalogue of Movies

    • Trending (Hero Image)
    • Popular
    • Top Rated
    • Upcoming
    • Modals with details for each movie
  • Filter by Genre

    • Action
    • Adventure
    • Fantasy
    • and more
    • Modal for filter options
    • Reset filter button

Hi @jcy2704, kindly try and follow the github/git flow. Meaning we create the PR from the feature branch into the develop branch
then into the master, but currently, we have the PR created in the develop branch. Let us keep that in mind. Thank you 💪

@jcy2704
Copy link
Owner Author

jcy2704 commented Apr 14, 2021

Wrong pull request

@jcy2704 jcy2704 closed this Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants